Bounties - Can I take the second one?

[nomolos]

The title says it all - I would contact you via your mailing list but it's been down for the last several months and I was hoping it would be fixed with the new design but it hasn't been. So, may I take the second bounty (in the small projects list)? If so, I assume you are meaning to change the meaning of the [right click on search tab] -> [search more] -> [repeat search] button?

Thanks

[Zootella]

Hi nomolos,

Yes, our mailing lists have been down for some time. But, we have this forum now, and will communicate with the open source community with it. (We will also be bringing the mailing lists back up soon.)

Yes, all of the bounties on our list are free for anyone to start working on. Please, document your progress and code here in the Forums and also on our wiki.

Let me know if you have any questions. Thanks!

[nomolos]

Alright, I've done that one - at least to the extent of the detail you've given me. It was actually merely commenting out a line that did it (although that means that all repeat search don't clear the box, so I actually did a bit more than that). Were you guys looking for a dialog or something to be popped up asking the user if they would like to clear the search or if they would like to start a new one?

[Zootella]

Great - make a page on the wiki listing the bounty, describing what you did, and showing the code change. Then, I'll have another person on staff review it.

[nomolos]

http://limewire.org/wiki/index.php?title=Program.Wishlist.SmallBounty2

(I set up a Program.Wishlist page on the wiki with everything listed and linked - the pages are right ready for whenever someone picks up the bounty)

[Sam]

Would it be possible for you to post a unified diff of the patch on the wiki? (diff with the -u option?)

If you'd like to update the bounties page to reflect this, that'd be great. :)

[nomolos]

Done --- I am just using the tigris subversion plugin for Eclipse so I hope that the diff is in a suitable format. I can fiddle with things if you want, I just won't have the time for a couple hours.

[nomolos]

Just wondering if anything had come from the posted code. Thanks.

[Sam]

Hi nomolos,

The patch looks good, and is surprising that it was so simple to change! I guess that means we did a good job keeping the code clean. :)

Since this is a bounty feature and has a price-tag associated with it, perhaps it could be fleshed out a little bit? I'm sure many people enjoy the current use of 'repeat search', with it clearing & then searching again. Maybe a new 'Get More Results' entry could be added, and that would trigger the new code (as opposed to changing the functionality of Repeat Search)?

Also, is it necessary to reset the filters [the resetFilters() call in repeatSearch(boolean)] if the table isn't being cleared?

Thanks.

[nomolos]

Hi Sam,

Yes, I'll be able to flesh it out some more for sure :) Thanks for letting me know what else should be added.

[nomolos]

Changes have been done, and added to the wiki page (http://limewire.org/wiki/index.php?title=Program.Wishlist.SmallBounty2). Let me know if anything else is needed to be fixed. This one adds the additional button (and changes the action of the first one back), and makes sure that the (re)filtering is only done at the appropriate times. As well, I inserted the string into the localization setup, but only in English since I do not know any other languages.

[Sam]

That's great, thanks! We'll take a look over it next week and post some feedback. Could you modify the bounties page ( http://www.limewire.org/wiki/index.php?title=Bounties ) to show that this item is in progress & link to it? Thanks. :)

[Sam]

I've incorporated this patch into the repository. It'll be in the next beta release of LimeWire. You can see the change at https://www.limewire.org/fisheye/changelog/limecvs/?cs=MAIN:sberlin:20060420193745 .

Please go ahead and update the Wiki to include yourself under 'Completed Project Credits' and removing the item from 'Small Projects'. You can also send me an email to sam at limewire.com and we'll arrange for your bounty to be sent. :)

Also, if you want your real name listed, we can list it in the About window of the program (at https://www.limewire.org/fisheye/viewrep/limecvs/gui/com/limegroup/gnutella/gui/AboutWindow.java?r=1.35#l228 ). Let me know. :)