Upload settings ignored in 4.12.1 Pro ?

[stief]

While sharing a single large, popular file, saw 10 clients queued and only 2 more were getting the file. The uploads setting in the preferences allow for 25 slots, and 20 per person. Am I not understanding how the preferrence settings work?

Details at http://www.gnutellaforums.com/showthread.php?t=57406

A bit of a stack trace zipped and attached.

[stief]

Also, the uploads column in the Library still shows 0/0, even though the file has been uploading steadily for over an hour.

However, the Locations column HAS been updating, and now shows 140 locations.

[stief]

"stop sharing this file" in the Library did not work.

After 1/2 hr of killing uploads from the Monitor Pane, I had to move the file from the shared folder to the desktop before Monitor would show "file not found."

Sheesh. What's going on with all the upload/sharing settings :confused:

[Aaron.Walkhouse]

It was a pretty big change in the code. You've gotta expect the doors and
steering wheel to fall off a few times. Buckle up! :D

[stief]

Of course.

Yet, I thought the upload code hadn't been changed over to NIO.

[Sam]

There was a bug with uploading for a long number of years in that it allowed way too many uploads at once. LimeWire should have not allowed another upload if there soft-max was hit and there wasn't an upload going over 3KB/s. Instead, it was looking for 3B/s.

Other than that bug being fixed, there shouldn't be any changes at all in uploading code.

[stief]

Thanks for that explanation of the old bug. I don't see how it affects user settings, though.The uploads setting in the preferences allow for 25 slots, and 20 per person. Am I not understanding how the preference settings work?Is it that soft_max has nothing to do with the user settings in the preferences?

[Sam]

It should be working as follows:

25 is the "hard max" (set from options)
5 is the "soft max" (not settable from options)

If you're over the hard-max limit, no more uploads are allowed.
If you're under the soft-max limit, the upload is allowed.
Otherwise (if you're between the hard max & soft max range), then the upload is only allowed if atleast one upload is going over 3KB/s.

Granted, this isn't the best scheme in the world, but it gets the job done.

[stief]

If it works--great. Thanks for taking a moment for the explanation.

Sorry for being dense, but I still can't see why the queued uploaders were being interrupted or having to wait: slots and bandwidth were available, and I *think* it was still under the soft_max limit. The screenshot isn't an oddity: most of the day I noticed there were rarely more than 2 uploads actually happening.

http://www.gnutellaforums.com/attachment.php?attachmentid=2534&d=1150594215

[Sam]

Whelp, turns out we messed up. The last release that was correct was 4.11.3. Guess we'll be putting out a 4.12.3 and *that* will be it. :)

Thanks a million for pointing this out.